search

eddmann / serverless-fargate

Maintain long-running Fargate ECS tasks within your Serverless project
53 stars 22 forks source link

add support for volumes #35

Closed aydinschwa closed 1 year ago

aydinschwa commented 1 year ago

The "volumes" configuration does not have an associated schema, so it does not appear in the generated Cloudformation template. This PR adds a schema for "volumes".

aydinschwa commented 1 year ago

@eddmann Could this be merged? Thanks!

eddmann commented 1 year ago

Hey, thanks for the PR, sorry for the delayed reply, just wondering is this functionality possible using the supplied cloudFormationResource property? This should allow you to define any additional CloudFormation specific resource properties you wish to to define. For example, perhaps something like:

fargate:
  tasks:
    my-task:
      ..
      cloudFormationResource:
        task:
           Volumes: ...
aydinschwa commented 1 year ago

Ah sorry about that, I wasn't aware of that functionality. Thanks for your help, I'll close the pull request now!