Hoene84
commented
11 years ago I like it how you are expressing "why the fuck did you delete this" :-)
Well, shuffle has changed, repeat is not implemented. (see Imlementations of PlayOrderStrategy)
Repeat: I postponed the implementation because i never used this feature for myself. Unlike a CD or tape, mobile phone players tend to never stop, i never had the issue to listen an album once and then... remove my earplugs and... dunno. I think this should be an issue has to be done but has no priority.
Shuffle: this is more interesting. Had some problems implementing a proper back/next with random. If i looked how other players done this, i thougth it's not really consitent. So, whats consitent ? I tend to implement it (it's implemented now more or less like this) like: back/next is dependent to the order, anytime. next shuffle is another action. Shuffle like we know consits now of "what happens if current track ends?". That means you have 3 options instead of 4, prev/next/random. And an option to play random track instad of next when the current track ends. So far so good, now i want to get back after changing to shuffle. Or to show the issue more clear, next/next/toShuffle/next/back/back. Whats the result? whats the result after next/toShuffle/next/toSorted/back/back. Somehow not consitent. At the end i decided to have:
- back/shuffle/next as interacitve possibilities.
- next/random as automatic next. (The current impl. changes to shuffle on long click dices/shuffle)
- next in History/back in History independent of shuffle or not and any intermediate changes between. (not implemented yet)
hope its understandable, otherwise try to implement the back/next by the conventional way. You will come to a point you will say yourself "wtf, i have no idea what back should mean in this case".
eddturtle
Is the shuffle track in the settings view now no longer needed?
Same for the repeat checkbox.