eddycharly / terraform-provider-kops

Brings kOps into terraform in a fully managed way
Apache License 2.0
86 stars 20 forks source link

Cilium default config #1061

Open ddelange opened 1 year ago

ddelange commented 1 year ago

Hi :wave:

I wanted to change my cluster spec:

   networking {
-     calico {}
+     cilium {}
   }

And found that two arguments are required, although docs state there are default values for these booleans.

Is it intended?

│ Error: Missing required argument
│
│   on cluster.tf line 220, in resource "kops_cluster" "cluster":
│  220:     cilium {}
│
│ The argument "preallocate_bpf_maps" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on cluster.tf line 220, in resource "kops_cluster" "cluster":
│  220:     cilium {}
│
│ The argument "enable_remote_node_identity" is required, but no definition was found.

provider version 1.26.0-alpha.1

ddelange commented 8 months ago

note that cilium is the default network provider for new kops clusters as of 1.26 ref https://github.com/kubernetes/kops/blob/v1.28.2/docs/releases/1.26-NOTES.md

cilium vs calico benchmark: https://cilium.io/blog/2021/05/11/cni-benchmark/