search

eddycharly / terraform-provider-kops

Brings kOps into terraform in a fully managed way
Apache License 2.0
85 stars 20 forks source link

kubelet cpucfs_quota has no effect when set to false #385

Closed dkulchinsky closed 3 years ago

dkulchinsky commented 3 years ago

Hey there 👋🏼

Thanks for building this 😄

Trying to disable CPU CFS Quota on a couple of clusters (using latest stable - v1.21.0) by adding this to the cluster resource:

  kubelet {
    cpucfs_quota = false
  }

but the plan ends up with no changes.

I tried setting it on the instance_group resource level and got a diff, however when applied nothing happened and I didn't see any change in the cluster.spec

any advise?

eddycharly commented 3 years ago

Thanks for trying it out, it’s most likely a bug in the generated schema (terraform is not good at handling default values).

I’ll fix this tomorrow.

eddycharly commented 3 years ago

Should be fixed by https://github.com/eddycharly/terraform-provider-kops/pull/387

eddycharly commented 3 years ago

Closing, fixed in v1.21.2-alpha.2.