search

eddycharly / terraform-provider-kops

Brings kOps into terraform in a fully managed way
Apache License 2.0
85 stars 20 forks source link

1.21.3 always wants to remove secrets for ca cert #437

Closed argoyle closed 2 years ago

argoyle commented 2 years ago

Since upgrading to 1.21.3, terraform apply always wants to remove secrets for ca cert:

      ~ secrets {
          - cluster_ca_cert = (sensitive value)
          - cluster_ca_key  = (sensitive value)
            # (1 unchanged attribute hidden)
        }

It doesn't cause any harm to the cluster but there is always an update to apply.

eddycharly commented 2 years ago

Thanks for reporting. I’ll look into it asap.

argoyle commented 2 years ago

Just for extra info, I have not passed any specific CA cert into my cluster so those are the generated ones.

eddycharly commented 2 years ago

Did you provide a docker config secret ?

argoyle commented 2 years ago

Yes I did.

eddycharly commented 2 years ago

I think the fix is here https://github.com/eddycharly/terraform-provider-kops/pull/439 🤞

eddycharly commented 2 years ago

@argoyle can we close the issue now #439 was merged and released ?

argoyle commented 2 years ago

Yes, works fine! Closing.