search

eddyekofo94 / gruvbox-flat.nvim

Another attempt of a flat Gruvbox theme for Neovim
MIT License
243 stars 22 forks source link

lua query causes lua highlighting to break #24

Open jemag opened 1 year ago

jemag commented 1 year ago

This took me a while to figure out why my lua highlighting was now broken. Following https://github.com/neovim/neovim/issues/14090#issuecomment-1240357210, the added lua query causes lua highlight to break.

Currently

((identifier) @variable.builtin
 (#match? @variable.builtin "self"))

Does not extend the other queries, that is why it is breaking. Although you could extend like so:

;; extends
((identifier) @variable.builtin
 (#match? @variable.builtin "self"))

I think I would agree with with nvim-treesitter maintainer Clason comment that it is probably not worth it for a colorscheme to be adding these queries: image

eddyekofo94 commented 1 year ago

@jemag a PR with the fixes & I'll merge it