search

eddyekofo94 / gruvbox-flat.nvim

Another attempt of a flat Gruvbox theme for Neovim
MIT License
243 stars 22 forks source link

Align closer to gruvbox base16 highlighting #5

Closed kubejm closed 3 years ago

kubejm commented 3 years ago

First off, I would like to say thanks for working on this project! I have really enjoyed the theme!

I have been a longtime user of the following colorscheme: https://github.com/chriskempson/base16-vim/blob/master/colors/base16-gruvbox-dark-soft.vim

After switching to your theme, I noticed some differences with the treesitter syntax highlighting. The base16 highlighting seemed to have a bit more variety in highlighting some of the elements with different colors, specifically the this keyword within TypeScript.

I have attached a handful of images below to demonstrate the differences.

base16 gruvbox dark soft base16-gruvbox-dark-soft

gruvbox-flat as-is gruvbox-flat-as-is

gruvbox-flat to-be gruvbox-flat-to-be

One thing to note about my color selections within the PR is that I pulled them from https://github.com/morhetz/gruvbox for orange2 and aqua. I think they fit alright with your theme, but if you're using a flat calculation to find a new representation, then I can adjust them as you see fit.

Thanks again and interested to hear your thoughts!

eddyekofo94 commented 3 years ago

This now looks like a mergeable PR. 🙏🏾