After switching to your theme, I noticed some differences with the treesitter syntax highlighting. The base16 highlighting seemed to have a bit more variety in highlighting some of the elements with different colors, specifically the this keyword within TypeScript.
I have attached a handful of images below to demonstrate the differences.
base16 gruvbox dark soft
gruvbox-flat as-is
gruvbox-flat to-be
One thing to note about my color selections within the PR is that I pulled them from https://github.com/morhetz/gruvbox for orange2 and aqua. I think they fit alright with your theme, but if you're using a flat calculation to find a new representation, then I can adjust them as you see fit.
Thanks again and interested to hear your thoughts!
First off, I would like to say thanks for working on this project! I have really enjoyed the theme!
I have been a longtime user of the following colorscheme: https://github.com/chriskempson/base16-vim/blob/master/colors/base16-gruvbox-dark-soft.vim
After switching to your theme, I noticed some differences with the treesitter syntax highlighting. The base16 highlighting seemed to have a bit more variety in highlighting some of the elements with different colors, specifically the
this
keyword within TypeScript.I have attached a handful of images below to demonstrate the differences.
base16 gruvbox dark soft![base16-gruvbox-dark-soft](https://user-images.githubusercontent.com/8680565/120075158-26833280-c06e-11eb-8e29-b8e23b0f24fc.png)
gruvbox-flat as-is![gruvbox-flat-as-is](https://user-images.githubusercontent.com/8680565/120075159-27b45f80-c06e-11eb-99fd-35900f4124f0.png)
gruvbox-flat to-be![gruvbox-flat-to-be](https://user-images.githubusercontent.com/8680565/120075160-27b45f80-c06e-11eb-9e52-6989149db7b9.png)
One thing to note about my color selections within the PR is that I pulled them from https://github.com/morhetz/gruvbox for
orange2
andaqua
. I think they fit alright with your theme, but if you're using a flat calculation to find a new representation, then I can adjust them as you see fit.Thanks again and interested to hear your thoughts!