Closed Scrum closed 4 years ago
@eddyerburgh ping ?
Great job upgrading things!
A couple things that might need cleaned up:
jsdom-global
and browser-env
, and I don't think you need both.window.Date = Date
, which I think is to work around a bug in prettier
, but that really should have a comment so the reader knows why it's there.jsdom-global
, you'd need to add it (jsdom
) to dependencies. Right now you're bringing the core jsdom
package in via a transient dependency from browser-env
.Overall though it's awesome to see this modernized, and I'd love to see a new speed test now that Ava has seen a few major version bumps!
@pearofducks Hi
Overall though it's awesome to see this modernized, and I'd love to see a new speed test now that Ava has seen a few major version bumps!
I already did this, just forgot to do PR, thanks for reminding me)
Regarding jsdom
I added comments and links to sources of the reason for the need to use this design
Looks good, can't browser-env
be removed then? Or is it adding some functionality I don't know about?
Looks good, can't browser-env be removed then? Or is it adding some functionality I don't know about?
@pearofducks yep, see last commits )
Probably also need to add jsdom
as a dependency. It was coming in via browser-env
before.
@pearofducks Yes, you are absolutly right, done.
@pearofducks @eddyerburgh ping ?
Looks good, one small nitpick comment and I also need you to add @babel/runtime as a dev dependency.
Thanks for making the changes. I just tested the dev
script and it seems to be broken, could you also fix that and the build
script?
Oh sure
@pearofducks @eddyerburgh done
Thanks. The dev script is fixed, but I'm still getting an error when I run the build script:
Error: webpack.optimize.UglifyJsPlugin has been removed, please use config.optimization.minimize instead.
oh yes technology is developing rapidly) fixed
Tahnk you @Scrum 😄
I could deal with this project if you allow