test: fixed - Githubissues

eddyerburgh / vue-test-utils-ava-example

An example vue-test-utils project with AVA

30 stars 3 forks source link

Closed Scrum closed 4 years ago

Scrum commented 4 years ago

I could deal with this project if you allow

Scrum commented 4 years ago

@eddyerburgh ping ?

pearofducks commented 4 years ago

Great job upgrading things!

A couple things that might need cleaned up:

You're loading both jsdom-global and browser-env, and I don't think you need both.
You added window.Date = Date, which I think is to work around a bug in prettier, but that really should have a comment so the reader knows why it's there.
If there was a decision to keep jsdom-global, you'd need to add it (jsdom) to dependencies. Right now you're bringing the core jsdom package in via a transient dependency from browser-env.

Overall though it's awesome to see this modernized, and I'd love to see a new speed test now that Ava has seen a few major version bumps!

Scrum commented 4 years ago

@pearofducks Hi

Overall though it's awesome to see this modernized, and I'd love to see a new speed test now that Ava has seen a few major version bumps!

I already did this, just forgot to do PR, thanks for reminding me)

Regarding jsdom I added comments and links to sources of the reason for the need to use this design

pearofducks commented 4 years ago

Looks good, can't browser-env be removed then? Or is it adding some functionality I don't know about?

Scrum commented 4 years ago

Looks good, can't browser-env be removed then? Or is it adding some functionality I don't know about?

@pearofducks yep, see last commits )

pearofducks commented 4 years ago

Probably also need to add jsdom as a dependency. It was coming in via browser-env before.

Scrum commented 4 years ago

@pearofducks Yes, you are absolutly right, done.

Scrum commented 4 years ago

@pearofducks @eddyerburgh ping ?

eddyerburgh commented 4 years ago

Looks good, one small nitpick comment and I also need you to add @babel/runtime as a dev dependency.

eddyerburgh commented 4 years ago

Thanks for making the changes. I just tested the dev script and it seems to be broken, could you also fix that and the build script?

Scrum commented 4 years ago

Oh sure

Scrum commented 4 years ago

@pearofducks @eddyerburgh done

eddyerburgh commented 4 years ago

Thanks. The dev script is fixed, but I'm still getting an error when I run the build script:

Error: webpack.optimize.UglifyJsPlugin has been removed, please use config.optimization.minimize instead.

Scrum commented 4 years ago

oh yes technology is developing rapidly) fixed

eddyerburgh commented 4 years ago

Tahnk you @Scrum 😄