eddysilvamendes / jquery-star-rating-plugin

Automatically exported from code.google.com/p/jquery-star-rating-plugin
0 stars 0 forks source link

Cancel rating does not submit form via AJAX #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create form with star rating plug-in.
2. Set callback on these features to use '$(this.form).ajaxSubmit()'
3. Click on the 'Cancel Rating' button
4. The form is not submitted to the server (most likely because of the
jquery selector used should not be $(this.form) for the cancel rating button).

What is the expected output? What do you see instead?
Form to be submitted via AJAX Form Plugin.

What version of the plugin/jQuery are you using?
PLUGIN VERSION: 3.12
JQUERY VERSION: 1.32
JQUERY FORM VERSION: 2.25

On what browser(s) or operating system?
BROWSER(S): IE, Firefox

Please provide a link to where the problem can be observed:
URL: (cannot provide)

Feel free to provide any additional information below.

Original issue reported on code.google.com by doraz1...@gmail.com on 30 Apr 2009 at 7:35

GoogleCodeExporter commented 8 years ago
This appears to be an issue with the data being passed to the callback for the 
cancel
button. The callback is receiving value as an empty string and link as what 
appears
to be the first link that is in the DOM.

Original comment by aron.duby@gmail.com on 20 May 2009 at 12:00

GoogleCodeExporter commented 8 years ago
Hs this been fixed?  It's a pretty basic bug.

Original comment by briggs.e...@gmail.com on 19 Aug 2009 at 9:04

GoogleCodeExporter commented 8 years ago
Anyone have a work around?

Original comment by jrberg2%...@gtempaccount.com on 28 Sep 2009 at 1:14

GoogleCodeExporter commented 8 years ago
Yes. Create a new action, bind it to the cancel button (when it is created in 
this 
plugin) w/the form/value (via context variable). I cannot post the code for it 
(sorry), 
but if you know a little bit about jQuery plugins, it should not be too hard. 
If you 
have an ajaxSubmit action bound to it, call that (from the new cancel action) 
with the 
form. As the plugin sits now, it will post the entire document back to the 
server, not 
just the form.

Original comment by doraz1...@gmail.com on 28 Sep 2009 at 1:37

GoogleCodeExporter commented 8 years ago
I futzed with it, and got something where the cancel button calls supplies the 
right
form element without changing the structure of the callback.  This works for 
what I'm
doing.

File attached, but keep in mind I don't know anything about javascript, so was 
mostly
guessing.  Sorry it's not in patch form.

Original comment by visibleg...@gmail.com on 7 Jan 2010 at 9:20

Attachments:

GoogleCodeExporter commented 8 years ago
I've tested the fix with jquery 1.4.2 and jquery.rating 3.13 and it works as 
expected. I turned it into a patch, if it 
helps. 

Original comment by carlo.ca...@gmail.com on 30 Apr 2010 at 5:59

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch - it works great.  Hopefully they'll fix this in 3.14?

Original comment by analytic...@gtempaccount.com on 20 May 2010 at 3:43

GoogleCodeExporter commented 8 years ago
It looks like the patch downgrades the plugin to 3.12 and doesn't match the 
3.13 I downloaded.  Line numbers and contents are wrong

Original comment by iguanag...@gmail.com on 19 Dec 2011 at 8:20

GoogleCodeExporter commented 8 years ago
Thanks, Cancel not working as one would expect was driving me insane.I merged 
it with 3.14 which is almost the same as 3.13.

Original comment by stevedef...@gmail.com on 14 Dec 2012 at 3:40

GoogleCodeExporter commented 8 years ago

Original comment by diego.a...@gmail.com on 23 Feb 2013 at 5:12