search

eddyson-de / react-grid

Customizable data grid for React.js
MIT License
4 stars 0 forks source link

Replace `hideTools` prop #499

Closed jochenberger closed 6 years ago

jochenberger commented 6 years ago

The prop is awkwardly named, because it only hides the filter. Also, I'm not sure whether it should remain a prop of the Column component, e.g. filterable={false}. It's similar to sortable, but we might also argue that it should be <Column ...><Filter hide /></Column>.

fkretzer commented 6 years ago

I would prefer <Column ...><Filter hide /></Column> as this more consistent with the declarative 1.0 API