search

edelight / chef-solo-search

Data bag search for Chef Solo
Apache License 2.0
177 stars 2 forks source link

Add tests for role searches and support for .rb role files #44

Closed wheresalice closed 10 years ago

wheresalice commented 10 years ago

I'm open to suggestions on how to do the .rb role files better, assuming the filenames are the same as the rolenames isn't necessarily correct.

wheresalice commented 10 years ago

That Travis error doesn't look like it's anything that I've touched in this change. It's claiming "Gem::InstallError: mime-types requires Ruby version >= 1.9.2." but it's done two builds on Ruby 1.8 and one of them works just fine.

tobami commented 10 years ago

I just triggered a rebuild on travis and everything is green now

tobami commented 10 years ago

Otherwise looking good, though you could update the roles section in the README.md to make clear that .rb roles are supported

tobami commented 10 years ago

@kaerast do you want to add a note to the README yet? Are you still interested in integrating this feature?

wheresalice commented 10 years ago

Sorry it's taken so long for me to get round to updating the README, I've simply not had chance to come back to this.

tobami commented 10 years ago

No problem, thanks for it. It conflicts because I move yesterday "Nodes" below "Databags" I guess. Can you try to resolve it by merging master into your branch? Otherwise I can just merge into master and resolve conflicts at that point. It's just cleaner the other way

michaelglass commented 10 years ago

this looks great. merging.