edelooff / sqlalchemy-json

Full-featured JSON type with mutation tracking for SQLAlchemy
http://variable-scope.com/posts/mutation-tracking-in-nested-json-structures-using-sqlalchemy
BSD 2-Clause "Simplified" License
189 stars 34 forks source link

setup.py claims support for Python 2 but code actually requires Python 3 #40

Closed FelixSchwarz closed 1 year ago

FelixSchwarz commented 1 year ago

Your setup.py claims Python 2 support but TrackedList.sort() uses a keyword-only parameter which is only valid for Python 3.

Probably Python 2 support is a non-goal by now so I suggest:

If you like I can create a pull request to fix this issue.

edelooff commented 1 year ago

That's a good point, and yes, Python 2 compatibility is no longer a goal. Happy to accept the PR.