edelstone / material-palette-generator

🎨 Get perfect Material Design palettes from any hex color.

https://materialpalettes.com

210 stars 25 forks source link

Fix to support dialog bug on iOS #7

Closed ziyafenn closed 4 years ago

ziyafenn commented 4 years ago

Fixed iOS bug with dialog appearing always on top.

Also, removed tabindex="1" from the exportButton because on iOS it would automatically focus/scroll down to that button.

p.s. sorry for linter, it decided to prettify code again...

Only thing i change is how the modal being displayed.

6

edelstone commented 4 years ago

I see a few issues with this @ziyafenn.

There are two conflicting files that need resolution (linter related?).
I'm noticing that when the page loads the "color copied to clipboard" message is present at the bottom, and all of the circled color swatches transition from square to circle. Maybe there is a new CSS rule specifying a transition for all?

Take a look and get back to me.

edelstone commented 4 years ago

Looking again, the second problem may predate these recent PRs. Seems new though.

ziyafenn commented 4 years ago

@edelstone yeah, two files changes, css file (i set display:none by default to the modal) and export.js to utilize than new css property.

About the second issue, i didn't touch any global variables. Only things related to modal, button and textarea. And i think I've noticed that behaviour previously as well.

edelstone commented 4 years ago

@ziyafenn Would you mind pulling the recent changes from edelstone:master and merge those with your branch so you can resolve the conflicts locally and then push again?

Below is what I see on my end. Pretty sure you kept working on your branch without pulling recent changes we already merged.

ziyafenn commented 4 years ago

@edelstone sorry, forgot to first pull the changes from your master.

Can you please check if everything works. If yes, you can accept the PR.