Always use id when consructing Component objects

edelvalle / reactor

Phoenix LiveView but for Django

630 stars 25 forks source link

Always use id when consructing Component objects #20

Closed kbni closed 2 years ago

kbni commented 3 years ago

Hi @edelvalle! Great module. I'm just experimenting, but I found if a component is nested inside another component, I found that id was not being set properly as it was not included in Component._build if _parent_id is set.

Disclaimer: I've only very briefly looked at the internals and unfortunately my Python segfaults when I try to run tests.py, so apologies if this is not a useful PR.

edelvalle commented 3 years ago

If you could provide me with an example of code, so I can test this...

edelvalle commented 2 years ago

Thanks for the PR