[Bug]: Github theme URL highlight not visible

[adriansticoid]

What happened?

So this is how it looks like when a URL is highlighted with the Chrome refresh theme:

And this is how it looks like with the Github theme:

I swear that's highlighted but it's not visible. This is the only issue I found so far. Really love the theme and thanks for your work.

Steps to reproduce

1. Activate Github theme
2. Try to highlight a URL

Additional info (Optional)

No response

[AzuredBlue]

Noticed the same, color-mix() expects a percentage, but its using a number Until its fixed, a fix is to change the 0.4 in --md-selection-background-color (where you added the theme) to 40%

[adriansticoid]

@AzuredBlue Hi, from --md-selection-background-color: color-mix( in srgb, transparent 0.4,

I changed it to --md-selection-background-color: color-mix( in srgb, transparent 40%,

and the issue persist. Did I do it incorrectly?

[AzuredBlue]

@AzuredBlue Hi, from --md-selection-background-color: color-mix( in srgb, transparent 0.4,

I changed it to --md-selection-background-color: color-mix( in srgb, transparent 40%,

and the issue persist. Did I do it incorrectly?

Hm, I have it set to

      --md-selection-background-color: color-mix(
        in srgb,
        transparent 40%,
        #388bfd
      );

and it works

Make sure it's the correct file, that its saved, and that you have restarted Firefox. If it still doesnt work then you could just remove the transparency and make it a single color by setting it to --md-selection-background-color: #388bfd; or simply remove it, so it will use Firefox's default selection background color

Either way it shouldnt take too long for a fix

[adriansticoid]

@AzuredBlue yep smooth brain moment. I was indeed trying to edit the wrong file. It looks correct and prettier now. Thank you so much!

[adriansticoid]

@AzuredBlue I found another one When hovering through suggested tabs, the highlight is not visible

Normal:

Github theme:

[AzuredBlue]

@AzuredBlue I found another one When hovering through suggested tabs, the highlight is not visible

Normal:

Github theme:

Seems to be because --md-background-color-50 and --md-menu-background-color-hover share the same color. You can simply change the latter to a lighter color. I used this with 10% (#28313e) and it looks like this:

Not sure if that will cause issues with anything else. I'll leave it to the repo owner to choose a better color if it does

[adriansticoid]

@AzuredBlue I copied what you did and yes it looks better now. Thank you. Will keep an eye out for more issues like this.