search

edemaine / coauthor

Coauthor supercollaboration/discussion forum
MIT License
249 stars 34 forks source link

Not enough space above images in dark mode #573

Open diomidov opened 3 years ago

diomidov commented 3 years ago

What's wrong?

If the last line before an image contains an inline fraction, there are approximately 0 pixels of black space between the fraction and image: image

It looks fine in light mode: image

(well, technically the spacing is exactly the same, but the dark theme has extra white borders around images)

How to Reproduce

Steps to reproduce the behavior, e.g., link to where to see the behavior:

  1. Go to https://coauthor.csail.mit.edu/coauthor-dev/m/nWAS9GooDt4zdELNm

Context

edemaine commented 3 years ago

Do you think I should just make the white border slightly fewer pixels? Or do we want the layout to actually differ between dark and light mode?

diomidov commented 3 years ago

I'm not sure if "slightly fewer" will be enough. When I first suggested the white outline, I assumed it would be a padding and not a border. That would leave slightly less space for the image, but the spacing would be more consistent between different modes.