edemaine / cocreate

Cocreate Shared Whiteboard/Drawing
MIT License
209 stars 27 forks source link

Zoom-to-fit, partially address #13 #114

Closed duetosymmetry closed 3 years ago

duetosymmetry commented 3 years ago

I don't particularly like the hotkey choice of '1', but '0' was already taken for resetting the zoom to 100%. IMO it makes more sense for the 100% hotkey to be '1', and the zoom-to-fit hotkey to be '0'.

duetosymmetry commented 3 years ago

Updated so Zoom to fit would work during Time Travel mode. Changed hotkey because I didn't realize that 1-7 were hotkeys for stroke widths. Shift-0 (i.e. )) was the best option I could see.

duetosymmetry commented 3 years ago

Note to self: there will be a merge conflict with other doc changes, specifically in the Time Travel section

edemaine commented 3 years ago

Thanks again for this PR! I've already used this feature a few times in class. 🙂

Hope you like the bug fixes, fit to selection feature, and new hotkey! Happy to continue to discuss/tweak/etc. of course.