edemaine / cocreate

Cocreate Shared Whiteboard/Drawing
MIT License
209 stars 27 forks source link

keyboard shortcuts for switching tools and widths (and colors?) #57

Closed adqm closed 4 years ago

adqm commented 4 years ago

I think this is really easy to implement, but I think it could also be a really big QoL improvement, since changing tools currently requires clicking/tapping on a small button.

I could imagine, for example:

Not sure if it makes sense to try to have something for colors as well...

edemaine commented 4 years ago

I agree this is important, but I hadn't done it yet because I think we need a lot of care in choosing the correct keys, because people will quickly memorize and then it'll be hard to change. Maybe I shouldn't worry so much, and feel free to break things in these early beta stages...

Plausibly we should have the keys be customizable, possibly with quick bindings to match Illustrator or Inkscape. I wasn't sure how many key overlaps there would be, but here's an analysis:

Tool Illustrator Inkscape
Pan h (hand), or #37 no analog (ctrl+drag pans)
Select v (pointer) F1
Pen n (pencil) p
Line segment \ no analog (b is close, but really polylines)
Rectangle m r
Eraser no analog (shift-e is area eraser) no analog
adqm commented 4 years ago

Yeah, I'm usually pretty reckless with things like that, but people do (rightfully) get upset with me because catsoop changes stuff all the time. So maybe it is indeed good to be a little careful...

I've never used Illustrator, and I don't have a lot of experience with Inkscape, so I'm not too familiar with those. I was just trying to think through what some sensible defaults might be, from first principles.

I like the idea of making the keybindings customizable (#16), and having a way to quick-select bindings from common vector drawing programs. I would probably argue that the defaults shouldn't be chosen based on other programs (both of the lists you shared above, and illustrator in particular, just seem weird to me!), but I could see an argument in the other direction.

edemaine commented 4 years ago

FYI, most of these are now live (see checklist above). Hope you like them!

edemaine commented 4 years ago

I think this can be closed for now, with #16 for custom keyboard shortcuts. History/time travel isn't particularly usable via a keyboard interface, so it probably doesn't need a shortcut? And I feel like hotkeys are more of a priority for the drawing modes/styles, not the uncommon operations in the bottom left.