Ideas for un-iframables

edemaine commented 3 years ago

[ ] See whether fetch can reliably predict (at least with no false negatives) whether a page can be <iframe>d.
[ ] Detect images and PDF files, and embed them directly (via <img> or pdf.js). I imagine some websites allow embedding of images but don't allow iframing them — should check. This could also let us manipulate the contents, though I'm not sure what we'd want — perhaps synchronized scrolling through PDFs, or seeing each other's cursors to point at those images/PDFs (though that starts to sound like embedding the PDF in Cocreate).
[ ] CORS proxy as in X-Frame-Bypass

seantrace commented 3 years ago

X-Frame-Bypass might help in some cases if you are happy with using such a workaround. It appears to only work in Chrome and Firefox however. (It did not work for Zoho Slide Broadcast links :-( ). Anyone know of any other slide presentation synchronization options which might work with comingle?

edemaine commented 3 years ago

@seantrace Thanks for the pointer to X-Frame-Bypass. Using a CORS proxy looks like a promising approach! I'll have to experiment with it. (And for Comingle we shouldn't actually need custom built-in HTML elements, so should be able to work on all modern browsers.)

Regarding slides, see #116. In particular, slides.com seems to embed fine in current Comingle.

seantrace commented 3 years ago

@edemaine Interested to hear how your experiments go. I was looking for a slides solution which enabled the presenter to step through the deck and for all sharing viewers to be kept in sync (maybe with option to manually drop out of sync and then hit a catch-up/resync button).

seantrace commented 3 years ago

Looks like I need to read all the issues! I thought you might be interested that I had some success removing CORS with CORSflare. Zoho Show Broadcast has some nasty CORS checking JS code which breaks it!

mehtank commented 3 years ago

A quick but mostly effective hack for your second bullet point above:

https://github.com/edemaine/comingle/blob/2694ff95d20b6ee5dc1c8efe2a912fd21a1026b7/client/TabIFrame.coffee#L50

Can be replaced by checking if the url ends with .pdf and using <embed width="100% height="100%"> instead of . Something similar for .png or .jpg too I'd imagine. Regexing any hashes after the extension would make it more robust (and e.g. allow direct linking to pages of a pdf). It won't handle corner cases when a server might use non-standard URLing, but it should cover most of it.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

edemaine / comingle

Ideas for un-iframables #126