Discrepancy about ordering of faces_edges between spec and example

edemaine / fold

FOLD file format for origami models, crease patterns, etc.

MIT License

314 stars 48 forks source link

Discrepancy about ordering of faces_edges between spec and example #37

Closed cryslith closed 1 year ago

cryslith commented 2 years ago

From the spec:

faces_vertices and faces_edges should align in start so that faces_edges[f][i] is the edge connecting faces_vertices[f][i] and faces_vertices[f][(i+1)%d] where d is the degree of face f.

The diagonal-cp and diagonal-folded examples violate this rule; these are the only examples which contain faces_edges. They say they were created with Crease Pattern Editor, so maybe this is a bug in that tool?

cryslith commented 2 years ago

I think this branch should fix the issue in CP-Editor, but I can't manage to build the FOLD library to check.

edemaine commented 1 year ago

Finally merged this and released in 0.11.4.