search

edemaine / solid-meteor-demo

Simple demo of SolidJS in Meteor
https://solid-meteor-demo.meteorapp.com/
MIT License
13 stars 2 forks source link

HMR #5

Open edemaine opened 2 years ago

edemaine commented 2 years ago

Meteor's Hot Module Replacement seems to automatically accept changes if you use JSX, which is not the right thing to do in a Solid context. See hmr branch, where it doesn't even seem to reload any code. This will probably need fixing in Meteor.

edemaine commented 2 years ago

Update: HMR is working now, on main branch! I'm just rerendering the entire app, though, instead of specific components (but still avoiding a reload).

Something more like Solid Refresh might be good for the future.

edemaine commented 2 years ago

HMR now only works when editing client/*, which isn't helpful as all the UI code is in ui/*. (Alas, I couldn't keep the code in client and get SSR working.)

The right place to fix this is edemaine:solid, and I've opened https://github.com/edemaine/meteor-solid/issues/2. This issue is blocked on that one.