cem and concept count tables are in the cdm_db not in the app db

edencehealth / ohdsi-glue

tool to facilitate the setup and ongoing maintenance of OHDSI & EHDEN tool deployments

GNU Lesser General Public License v2.1

0 stars 1 forks source link

cem and concept count tables are in the cdm_db not in the app db #43

Closed ziporah closed 5 months ago

ziporah commented 5 months ago

There is an issue creating concept_count tables in the cdm db, when mixing appdb as postgresql and cdmdb as sql server. I believe this patch fixes the issue

actualben commented 5 months ago

Thanks Jo, that's a very subtle bug! My read is that it will send the DDL to the correct database but it's fetching the wrong DDL dialect in cases like yours. I'll merge this now, but additionally I think the function get_results_ddl (from the same file) should be fixed too so I'll do that in a subsequent PR.

actualben commented 5 months ago

@ziporah Your fix is included in the v2.15 image: https://hub.docker.com/r/edence/ohdsi-glue/tags?page=&page_size=&ordering=&name=2.15