edeprince3 / pdaggerq

Apache License 2.0
44 stars 10 forks source link

Update CMake Config to Consistently Find Python #48

Closed Marclie closed 7 months ago

Marclie commented 7 months ago

Made a few tweaks to our CMake setup:

  1. Set Python3_FIND_STRATEGY to LOCATION to make sure CMake uses the Python from our current shell environment, like a Conda environment. This should avoid it picking up the system Python by mistake.
  2. Updated pybind11 settings to match the Python version found by CMake.
  3. Enforced requirement to use C++17 since the new foreach loop structure is not compatible with older versions.

This should fix a few issues where the wrong python version is being used.