edera-dev / krata

krata is a Xen control plane in Rust.
GNU General Public License v2.0
274 stars 11 forks source link

feature: exec tty support #335

Closed azenla closed 3 months ago

azenla commented 3 months ago

Right now, exec doesn't implement tty support. We should implement a tty flag and pass that through the stack, and let the exec handler allocate a tty.

jedsalazar commented 3 months ago

Not sure if I should put this here but I'm seeing terminal weirdness with attach, even after a reset

demo@bronze:~$ kubectl attach -it privileged
If you don't see a command prompt, try pressing enter.
^@
# ^@
# ^@
# ^@g^@r^@e^@p^@ ^@C^@a^@p^@ ^@/^@p^@r^@o^@c^@/^@1

The above is the output of

grep Cap /proc/1/
azenla commented 3 months ago

Not sure if I should put this here but I'm seeing terminal weirdness with attach, even after a reset

demo@bronze:~$ kubectl attach -it privileged
If you don't see a command prompt, try pressing enter.
^@
# ^@
# ^@
# ^@g^@r^@e^@p^@ ^@C^@a^@p^@ ^@/^@p^@r^@o^@c^@/^@1

The above is the output of

grep Cap /proc/1/

Hmm, I think this is due to terminal disagreement (IE control codes getting sent), will fix this in a follow up task.

azenla commented 3 months ago

Completed!