search

edesiocs / ingatan

Automatically exported from code.google.com/p/ingatan
Other
0 stars 0 forks source link

Clean up the image editor's event structure. #12

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
This is an improvement on an existing feature.

Describe the new feature should be added and what the current situation is.
Currently, when an event occurs on the canvas in the image editor, an if-else 
structure is entered that determines which tool is selected and what action 
should result. This is a monolith of code, because the code taking care of the 
resulting action is just part of the if-else structure. Each tool action should 
be made into a method, and then the if-else structure should call these methods.

How will this feature improve the usability of Ingatan?
This will improve the maintainability of Ingatan, and make it easier to add new 
tools if needed. It will also make it less daunting to look at the code if any 
bugs need sorting out. Even I find it scary going in there... and I wrote it.

Do you have any suggestions for code implementation?

Original issue reported on code.google.com by tom.eve...@gmail.com on 26 Jul 2010 at 11:39

GoogleCodeExporter commented 9 years ago

Original comment by tom.eve...@gmail.com on 3 Feb 2011 at 3:01

GoogleCodeExporter commented 9 years ago

Original comment by tom.eve...@gmail.com on 3 Feb 2011 at 3:02

GoogleCodeExporter commented 9 years ago 
Pushed back. Low priority.

Original comment by tom.eve...@gmail.com on 8 Feb 2011 at 7:39

GoogleCodeExporter commented 9 years ago 
I did all the refactoring needed (I think). Could someone review the code and 
perhabs commit it. I would appreciate feedback.

Original comment by nhe...@gmail.com on 11 Nov 2011 at 11:38

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks so much for your contribution! I'll review it ASAP, it's an unusually 
busy month for me. Cheers!

Original comment by tom.eve...@gmail.com on 20 Nov 2011 at 10:46