search

edestecd / puppet-clamav

Puppet Module for managing ClamAV
GNU General Public License v3.0
6 stars 59 forks source link

Spec Tests for clamav milter #31

Open edestecd opened 7 years ago

edestecd commented 7 years ago

@ubellavance when you get a chance let me know...

ubellavance commented 7 years ago

I'm setting a reminder for myself in about two months. I hope I'll have time before that.

ubellavance commented 7 years ago

I think I should be able to start soon. Where should I start? I looked a bit in the spec folder but couldn't totally make sense of it.

ubellavance commented 7 years ago

@edestecd?

edestecd commented 7 years ago

You need to add a new file: spec/classes/clamav_milter_spec.rb

Start out by copying clamav_spec.rb, then just modify to suit. You generally want a case with the defaults and then several cases where you set common parameters and assert what you expect.

ubellavance commented 7 years ago

Looks rather easy. I'll give it a shot some time soon. Thanks!

ubellavance commented 7 years ago

Hardest part may be to rebase, though 🙁

ubellavance commented 7 years ago

@edestecd I didn't have to rebase, good news. I did create the file, and added travis tests to my own repo, and it fails, but because of an unrelated reason. I know that it will probably fail on all OSs except RedHat and CentOS 7, but at least I would know if my tests work. I think I found how to define a specific OS for tests here. Does it make sense?

ubellavance commented 7 years ago

@edestecd?