edestecd / puppet-clamav

Puppet Module for managing ClamAV
GNU General Public License v3.0
6 stars 59 forks source link

Incorrect argument format for option <optionName> #33

Open Yamakasi opened 7 years ago

Yamakasi commented 7 years ago

On a puppetrun I get the following message when the ClamAV Daemon wants to start

May 5 14:01:43 mailscan-02 systemd[1]: Started Clam AntiVirus userspace daemon. May 5 14:01:44 mailscan-02 clamd[18391]: ERROR: Incorrect argument format for option AlgorithmicDetection May 5 14:01:44 mailscan-02 clamd[18391]: ERROR: Can't open/parse the config file /etc/clamav/clamd.conf

A default config from the ClamAV installation works well.

edestecd commented 7 years ago

What is your OS and version?

Yamakasi commented 7 years ago

Wow, quick reply! thanks.

Ubuntu 17.04

ubellavance commented 7 years ago

It's not on the list of supported OS versions: https://forge.puppet.com/edestecd/clamav/compatibility. Would you like to help us make it compatible?

Yamakasi commented 7 years ago

Sure I want to, I just need to figure out why it hangs on that... gimme a sec.

edestecd commented 7 years ago

While this module does not officially support that version, I am happy to add support, if you can help provide more detail...

Can you find out what the correct argument format is for AlgorithmicDetection? We are setting it here for all OSes: https://github.com/edestecd/puppet-clamav/blob/master/manifests/params.pp#L184

As a temporary fix you could set that to the proper format or have it removed like so:

class { 'clamav':
  manage_clamd  => true,
  clamd_options => {
    'AlgorithmicDetection' => undef,
  },
}
Yamakasi commented 7 years ago

Hi, the thing is that the format is proper, I get true where true/yes/1 can live. Normally these changes are not that huge so that's why I opened this ticket. Thanks already!

I think I'm missing something in the top of the file that needs to be loaded first ?

Yamakasi commented 7 years ago

OK, the puppetized install overwritten with a default clamd.conf gives the same error(s). Need to investigate.

Yamakasi commented 7 years ago

Found the issue, there comes ^M from github in the templates when you clone it. Or you guys have uploaded a template with ^M ?

Yamakasi commented 7 years ago

Please remove AllowSupplementaryGroups as it's removed from ClamAV 0.99.2

edestecd commented 7 years ago

25

edestecd commented 7 years ago

^M is a special character... Often thats a Windows carriage return new line issue. Are you using windows? It is possible that someone checked in a windows formatted template.

edestecd commented 7 years ago

Any news on this?