PR for issue #69 - compatibility with RHEL/Centos 8.x

edestecd / puppet-clamav

Puppet Module for managing ClamAV

GNU General Public License v3.0

6 stars 59 forks source link

PR for issue #69 - compatibility with RHEL/Centos 8.x #70

Closed flinkflonk closed 4 years ago

flinkflonk commented 4 years ago

This was actually easier than I anticipated.

The only change had to be made in the params, where I now set the service name to be a defined string (with the correct service name of course) while it stays undefined for RHEL/Centos 7.

Testing on my RHEL8 server, without the hack I used to circumvent the module's behaviour, showed no errors, and since the change is quite minimal I don't think it will break on RHEL7.

Michael Hinz

edestecd commented 4 years ago

Looks good to me. Thanx for the contribution!

edestecd commented 4 years ago

@flinkflonk looks like the build is failing now: https://travis-ci.org/github/edestecd/puppet-clamav

edestecd commented 4 years ago

I already merged this so if you have time could you make another PR? If not I will get to it eventually. It looks like $freshclam_service isn't defined for CentOS 6