search

edestecd / puppet-clamav

Puppet Module for managing ClamAV
GNU General Public License v3.0
6 stars 59 forks source link

remove sub classes inheriting params #9

Closed jlambert121 closed 9 years ago

jlambert121 commented 9 years ago

Making changes without tests makes me nervous - next stuff will be tests.

Remove sub classes inheriting params Fully qualify class inclusions Move package resource to install class

edestecd commented 9 years ago

Why do we need to subscribe to the packages? Most good package writers will restart the service on update...

Have you had a case of needing this?

edestecd commented 9 years ago

I noticed you changed $config_options in the clamd and freshclam classes did you update the var name in the erb templates?

jlambert121 commented 9 years ago

Most good package writers will restart the service - but not all. This just makes sure that it happens.

Templates updated as well now.

edestecd commented 9 years ago

OK, the subscribe to package thing is fine by me. Other than the comments I just made, everything else looks great. Thanks for your work. I can merge as soon as you fix the clamav::install var.