search

edestecd / puppet-mariadb

Puppet Module for managing MariaDB
GNU General Public License v3.0
3 stars 21 forks source link

mysql::deepmerge is deprecated #38

Closed minorOffense closed 3 years ago

minorOffense commented 5 years ago

The 8.0.0 mysql puppet module deprecated the deepmerge function.

edestecd commented 5 years ago

DO you know what the alternative is?

minorOffense commented 5 years ago

Haven't looked into it yet (I was gonna open a PR for it). I just tried using the 8.0.0 version, saw the error message and then saw the changelog for that version.

https://forge.puppet.com/puppetlabs/mysql/changelog#changed

The release came out like a week or two ago.

minorOffense commented 5 years ago

Looking at the mysql module, I think the deep merge is just a function on hashes now if you include puppet-stdlib

See https://github.com/puppetlabs/puppetlabs-mysql/blob/master/manifests/server.pp#L119

minorOffense commented 5 years ago

Aaaand looks like they undid the change: https://github.com/puppetlabs/puppetlabs-mysql/pull/1181

edestecd commented 3 years ago

Seems ok now, reoopen if necessary