search

edestecd / puppet-software

Puppet Module to install various Desktop Software
GNU General Public License v3.0
8 stars 7 forks source link

Support Slack in social section #1

Closed bittner closed 7 years ago

bittner commented 7 years ago

It would be nice to have Slack available for installation from the social section.

If I am not mistaken then there's not even a dedicated module for installing Slack on Puppetforge, yet. One reason more to include it in this module. Note: There is a dedicated Slack package on Puppetforge.

edestecd commented 7 years ago

I agree. I'm planning on switching to brew cask for mac apps soon... I can add it then

edestecd commented 7 years ago

Or feel free to make a PR if you have time

bittner commented 7 years ago

I am looking at the source of the slack module on Puppetforge, and I'm wondering why there are so many deps for Ubuntu, and why the Debian package from the Slack website wouldn't install that automatically.

For the rest of the task it's really just a few lines, as usual.

bittner commented 7 years ago

Would it be fine if I made a PR with just GNU/Linux (Debian/Ubuntu + Fedora) support for now? It would be a nicely short, slick solution, just an archive and a package declaration.

But no Mac and Windows for now. I have no easy way to test against those OSes.

edestecd commented 7 years ago

No problem on adding just Linux. I'll get the others later...