Add RSpec scenarios for Skype and Slack

edestecd / puppet-software

Puppet Module to install various Desktop Software

GNU General Public License v3.0

8 stars 7 forks source link

Closed bittner closed 7 years ago

bittner commented 7 years ago

More scenarios for this fantastic Puppet module. Enjoy!

bittner commented 7 years ago

I've identified the culprit:

software::params::skype_version is only defined for Darwin OSes.

I have to add this also the the elsif 'Ubuntu' clause.

bittner commented 7 years ago

This PR is now ready to merge. :sweat: :champagne: :beer:

edestecd commented 7 years ago

@bittner Looks excellent. I just had one comment about the gitignore

bittner commented 7 years ago

Thanks, it was fun! :1st_place_medal: :champagne: