search

edestecd / puppet-software

Puppet Module to install various Desktop Software
GNU General Public License v3.0
8 stars 7 forks source link

Add missing param declarations (Ubuntu, Windows) #16

Closed bittner closed 6 years ago

bittner commented 6 years ago

Tests on the roles of our control repo discovered that some param values are not set for Ubuntu and Windows. This PR adds them.

bittner commented 6 years ago

Note that this issue is related to STRICT_VARIABLES in the spec helper, which could be turned on as an alternative. A very similar scenario is discussed in https://github.com/joshuabaird/puppet-ipaclient/issues/63 (custom facts).

bittner commented 6 years ago

Puppet Lab's PDK has changed opinion about supported OSes and makes test runs fail with the latest version. The second commit addresses this issue and makes Debian a supported option in general.

See also: https://github.com/puppetlabs/pdk/issues/338

bittner commented 6 years ago

@edestecd This PR is ready for merging. Thank you!

bittner commented 6 years ago

Anything I still need to do to make you merge this PR?

edestecd commented 6 years ago

@bittner sorry for the delay. I have a few comments.

bittner commented 6 years ago

I hope the changes now do what they should. Thanks for your input!

bittner commented 6 years ago

Do you have any more comments before you can merge this PR?

bittner commented 6 years ago

@edestecd We want to open more PRs, and the changes in this PR would be needed to continue without fuss. Would you mind to merge it?

bittner commented 6 years ago

This PR now also updates the Skype installation. Now the skypeforlinux package is installed from official Microsoft repositories for both vanilla Debian and Ubuntu.

edestecd commented 6 years ago

The new errors are from a new rubocop check that was added today. We hit it in our puppet control repo today as well.

bittner commented 6 years ago

Thanks!

I'm now rebasing PR #15. Can you take a look at that later, too?