search

edestecd / puppet-software

Puppet Module to install various Desktop Software
GNU General Public License v3.0
8 stars 7 forks source link

Remove unneeded redirection (PDK progress indicator) #20

Closed bittner closed 6 years ago

bittner commented 6 years ago

The redirection of output to stderr can now simply be removed, i.e. use code like this:

- stage: validate
  script: pdk validate

- stage: test
  script: pdk test unit

See https://github.com/puppetlabs/pdk/issues/323#issuecomment-388158858 for reference.

edestecd commented 6 years ago

the new templates in pdk no longer use pdk in travis.

bittner commented 6 years ago

Alright. :thinking:

If the CI configuration proposed by Puppet Lab looks like this (aka "hard to memorize") we should probably do something about it.

bittner commented 6 years ago

the new templates in pdk no longer use pdk in travis.

They probably never did in the past.

edestecd commented 6 years ago

Yea that's the one. We use the stock PDK templates from that repo. We have discussed using PDK in our travis builds, but at this point I'm happy to just have a tool that can manage all those files I'm sick of syncing across all our modules ;)

edestecd commented 6 years ago

Its updated to use version 1.5.0 of the pdk templates. Did we need anything else here?

bittner commented 6 years ago

Well, it's @puppetlab's turn now.