edestecd / puppet-software

Puppet Module to install various Desktop Software
GNU General Public License v3.0
8 stars 7 forks source link

Add tab completion and fancy prompt to Git #4

Closed bittner closed 7 years ago

bittner commented 7 years ago

Would you be interested to have two additional features added to the Git class?

Using this could look like this:

  class { 'software::vcsscm::git':
    ensure          => present,
    bash_completion => true,
    bash_prompt     => true,
    gui             => true,
  }

bash_* because: it really just relates to Bash, and would be difficult to generically implement this for several shells (in an "autodetect shell" way).

If you think that would be a good addition, I would open a PR for that. Though, I would (have to) limit my contribution to a Debian/Ubuntu implementation. No Mac, no Windows, for now.

edestecd commented 7 years ago

Yes, I was actually going to add the tab completion myself for osx soon. As long as its optional, i'm not against any new feature.

edestecd commented 7 years ago

The example you have looks good to me