Add Bash tab completion and prompt for Git

edestecd / puppet-software

Puppet Module to install various Desktop Software

GNU General Public License v3.0

8 stars 7 forks source link

Add Bash tab completion and prompt for Git #6

Closed bittner closed 7 years ago

bittner commented 7 years ago

This adds two optional parameters to the Git (sub)module.

I should probably add some documentation, too ("how to use" or so).
How do you feel about tests? I've seen the spec folder.

Fixes #4.

edestecd commented 7 years ago

Don't worry about the tests. I need to update them so they work again.

bittner commented 7 years ago

I've also fixed some markup issues in the README, and added myself as a contributor. I hope that's fine.

bittner commented 7 years ago

The build fails for two reasons:

The Rakefile could do with some syntax love, obviously. (Not a rake expert myself, though)
The bundle exec rake test SPEC_OPTS='--format documentation' call also checks the libs (and reports violations there), which it probably shouldn't.

Not sure if you want to fix this too to reduce noise. :hear_no_evil:

edestecd commented 7 years ago

Yea I have a standard set of fixes that need applied to this module. I have done it to several others... This will fix all the errors you are seeing. I'll try and get to it tonight, if the power does not go out, that is. I'm in Florida and we are experiencing a mild case of hurricane Irma. :frowning: