edeustace / assets-loader

a play plugin to help with asset loading.
MIT License
31 stars 8 forks source link

Compatibility with Play 2.3 #35

Open jc7447 opened 10 years ago

jc7447 commented 10 years ago

Hi,

I'm trying to migrate an app from play 2.2 to 2.3 and I'm facing this error :

Caused by: java.lang.NoSuchMethodError: com.ee.assets.Loader.scripts(Ljava/lang/String;Lscala/collection/Seq;)Lplay/twirl/api/Html;

It's caused by this line :

Helper.loader.scripts("js")("javascripts/my_dir")

That's certainly because Play has moved his template engine into a separate project.

Any plan for Play 2.3 support ?

edeustace commented 10 years ago

Hi - Yes. Will need to see what it'll entail.

edeustace commented 10 years ago

Also they have changed how they work with client side assets - so would be opportune to research if it provides any options for this project.

nonameplum commented 10 years ago

Hi, have you any plans to make your plugin compatible with play 2.3.x in style like sbt-web?

It could be connection of sbt-uglify, sbt-gzip and sbt-digest plugins :)

edeustace commented 10 years ago

Hi, I'd like to get started on it yes, but my project is still on 2.2.1 and I'm time-poor at the moment. So - yes at some point but probably not in the next month or so.

Ed

On Fri, Sep 5, 2014 at 7:52 AM, nonameplum notifications@github.com wrote:

Hi, have you any plans to make your plugin compatible with play 2.3.x in style like sbt-web?

It could be connection of sbt-uglify, sbt-gzip and sbt-digest plugins :)

— Reply to this email directly or view it on GitHub https://github.com/edeustace/assets-loader/issues/35#issuecomment-54591072 .

HomeTriangle commented 8 years ago

Any Update?

edeustace commented 8 years ago

Hi @HomeTriangle - sorry it's pretty low priority for me at the moment. My project will probably be moving straight to play 2.4 soon, I might be able to have a look then, but I can't guarantee anything.