edf-hpc / unclebench

10 stars 4 forks source link

Platform parameters defined outside of platform.xml are not customisable #50

Open pierretr opened 5 years ago

pierretr commented 5 years ago

Only platform parameters in platform.xml files are customizable on the fly with ubench run --custom-params option. All parameters imported un platform.xml should be customizable too.

erothe commented 4 years ago

Can you please be more specific? Or can you paste here an example of the suggested behavior?

pierretr commented 4 years ago

Parameters from parametersets imported in platform files cannot be overwritten with ubench run --custom-params option. For example the following command :

ubench run --custom-params parameter_I_want_to_modify:custom_value hpl

will not work if _parameter_I_want_tomodify is defined in a parameterset initialized with values from outside platform.xml file and not redefined in platform.xml or in jube benchmark description files.
If you have the following in your platform file :

<parameterset name="set_with_parameter_I_want_to_modify" init_with="not.xml"/>

Parameters from _set_with_parameter_I_want_tomodify won't be customizable with "--custom-params" option. However with the following parameterset in platform.xml or Jube benchmark description file, customization of _parameter_I_want_tomodify will work :

<parameterset name="set_with_parameter_I_want_to_modify" init_with="not.xml">
    <parameter name="parameter_I_want_to_modify "> "This value can be overwritten with --custom_params"<parameter/>
</parameterset>