edfan / firehose

A class-picking website for MIT students.
35 stars 11 forks source link

Incorrect instructors? #5

Closed synicalsyntax closed 4 years ago

synicalsyntax commented 4 years ago

First off, thanks so much for updating the site! The entire undergrad class is super excited to see the updated course offerings and we were really struggling with scheduling classes without your site.

There's something I noticed: it seems that the instructors for certain courses don't match up with what the catalog currently says. For example,

On the other hand, courses like 18.06 do reflect instructors correctly.

Would this be an issue with the data scraper picking up the wrong data or values not being updated in storage properly?

edfan commented 4 years ago

Hmm, that's a good point. I'm currently pulling in the fall_instructors field on coursews, but it looks like in-charge is better at least for Course 6. Overall, it does seem like in-charge is better for the examples that I've looked at, so I'm going to push a change to switch to that.

edfan commented 4 years ago

Okay, resolved. (Might need to hard refresh to see the change.) I've changed the text to "In-charge:" for clarity.

Thanks for reporting this!