search

edgafner / dorkag

Issue Tracker repository for all Dorkag plugins
Other
5 stars 0 forks source link

[BUG]: Issues when repository has a space in the URL #132

Closed daveaglick closed 3 weeks ago

daveaglick commented 1 month ago

Describe the bug

With the most recent version, I can no longer pull down PRs and get the following error:

image

This was working up until a week or two ago. It looks like it's tripping on a space in our DevOps URL.   To Reproduce Steps to reproduce the behavior:

  1. Click on the AZD pane to view PRs.
  2. It successfully connects and retrieves a list of open PRs.
  3. Double-click to open one.
  4. Error appears.

Expected behavior The PR is opened and a review can take place.

Screenshots

image

Desktop (please complete the following information):

JetBrains IDE (please complete the following information):

Azure Devops organization details:

Additional context Add any other context about the problem here.

awaters8 commented 1 month ago

This is very similar if not the same as #53 . I am also experiencing this in 2024.2.25 using PHPStorm 2024.2.3

daveaglick commented 1 month ago

If I downgrade to AZD 2024.2.14 it works again, so definitely a regression in the latest version (2024.2.25).

awaters8 commented 1 month ago

That's good to know, thanks!

Jonatha1983 commented 1 month ago

@daveaglick @awaters8 A new version with a fix was uploaded. Once JetBrains approves it, it will be available in the upcoming days.

daveaglick commented 1 month ago

Awesome, thanks! This extension has quickly become one of my most critical, thanks for staying on top of it.

vpetrigo commented 1 month ago

The issue still seems to be here.

IDE: CLion 2024.2.2 Plugin version: 2024.2.26 image

Plugin version: 2024.2.14 image

The interesing part here is that with the 2024.2.26 some PRs can be opened properly. I have not found a pattern which PRs can be opened and what cannot though. 😒

Jonatha1983 commented 1 month ago

@vpetrigo Thanks for the info.

Can you let me know if removing the user from the AZD setting, restarting the IDE, and re-logging in fixes the issue? I am afraid that there is some caching going on with my code.

vpetrigo commented 4 weeks ago

@Jonatha1983, thank you for the recommendation! I made the following steps with the 2024.2.26 plugin installed:

  1. Go to File -> Settings -> Version Control -> Azure DevOps
  2. Remove my previously registered organization account (I had only one at those time)
  3. Go to File -> Invalidate Caches..., selected all checkboxes, press "Invalidate and Restart"
  4. Generate a new PAT in the DevOps
  5. Add it to the Azure DevOps plugin

Unfortunately, that did not help. 😒 After rolling back to 2024.2.14 everything works. Let me know if you want me to try something else.

Jonatha1983 commented 4 weeks ago

Ok will keep investigating thanks for trying that

vpetrigo commented 3 weeks ago

IDE updated the plugin to the version 2024.2.31. No more Illegal character in path at index errors for me.

Another error pops up though. Like in the issue #138:

Failed to load pull requests.
HTTP Request Request GET https://dev.azure.com/<company>/<project with spaces in its name>/_apis/wit/workitems?ids=4815&fields=System.Id,System.TeamProject,System.WorkItemType,System.Title,System.AssignedTo,System.ChangedDate,System.CreatedDate,System.State&api-version=7.2-preview.3 failed with status code 404 and response body:
Jonatha1983 commented 3 weeks ago

@vpetrigo can you please install version 2024.2.32 and let me know if it solves this problem?

Thanks

vpetrigo commented 3 weeks ago

@Jonatha1983 just installed that version and checked several projects with PRs. Everything looks good for me, no more error messages mentioned in this thread.

Thank you for fixing that!

Jonatha1983 commented 3 weeks ago

Thanks for updating.

This version contains the ability to tag users in comment like this: @vpetrigo

Enjoy!