search

edgafner / dorkag

Issue Tracker repository for all Dorkag plugins
Other
5 stars 0 forks source link

[FEATURE]: Auto close feature #148

Closed mat-kap closed 1 week ago

mat-kap commented 2 weeks ago

As pull request creator I want the ability to use set the pull request to automatically complete when all policies succeed from the web view.

Jonatha1983 commented 2 weeks ago

Hi @mat-kap

You mean this: image

?

mat-kap commented 2 weeks ago

Hi @Jonatha1983

yes I mean this. Most of the time I've small changes or bugfixes and I'm always use the auto-complete feature for that. It would be great to have that.

Jonatha1983 commented 2 weeks ago

Will add that to the backlog of the next release.

** need to check if this is supported by the API, I think it is supported but not 100% sure.

awindillman commented 6 days ago

@Jonatha1983 Excited to try this. Looked everywhere. Cannot find it (I am on the latest). Also can't find link work items -- so perhaps related?

Jonatha1983 commented 6 days ago

Hi @awindillman what version of ide and what version of the Azd plugin?

awindillman commented 6 days ago

Hi @awindillman what version of ide and what version of the Azd plugin?

IntelliJ 2024.3 with AZD 2024.3.8.

Jonatha1983 commented 6 days ago

@awindillman You can't see the link work-item menu actions when right-clicking on a pull request details? Can you send me a screenshot?

Regarding autocomplete, the button to set autocomplete or to cancel is visible only in case the PR cannot be completed following the same convention as the Azure Devops portal.

There is no logic to set auto complete if you can just click complete because it will just complete.

awindillman commented 6 days ago

image

Autocomplete is available on the portal when clicking on the link through the AZD timeline. But I do not see it in IntelliJ through AZD.

Jonatha1983 commented 6 days ago

@awindillman You need to open the pr by double Click or right click + show details

Then in the pr details you should see all

awindillman commented 6 days ago

Tried that. Here is that same PR: (image removed)

Jonatha1983 commented 6 days ago

@awindillman Right-click on the details and you should see the link work item action

Also in the more actions (the 3 dots at the bottom younshold be able to see autocomplete ) or try to approve the pr and you should see the button instead of request reviewer

awindillman commented 6 days ago

@awindillman Right-click on the details and you should see the link work item action

I am not clear what "details" meant. So I started clicking everywhere on the UI to find the correct pop-up menu.

In doing so I found that right-clicking to the right of the title on the timeline brings up a menu that blinks super-fast, but never really appears. It continues the blinking for about 30 seconds. Unfortunately, I could not capture a picture, but it reproduces every time.

Right-clicking on files brought up the dialog that included the link work items (yay): image

Also in the more actions (the 3 dots at the bottom younshold be able to see autocomplete ) or try to approve the pr and you should see the button instead of request reviewer

I don't see that: image

Jonatha1983 commented 6 days ago

Hi @awindillman

  1. About the title, I will try to reproduce
  2. About the link work item double, yay :)
  3. There is a bug in the plugin that shows the autocomplete button only for approved PR, but with other blocking policies, I am fixing it and will release a new version soon. If you approve the PR, you should be able to see the button (but keep it blocked for completion for other reasons, such as CI, not linked work items, etc.).
Jonatha1983 commented 6 days ago

This is the bug:

https://github.com/user-attachments/assets/ebfa234c-1efa-49cc-9af1-49f4cfe48a31

I also added the auto complete to the more actions (the three vertical dots)

awindillman commented 6 days ago

I was able to make it work with the limitations you described.. almost. There was one more critical limitation required. Under no circumstances can I set AutoComplete on my own PR. However, I can set it on the PRs of others once I approve. In our case we set our own PRs to AutoComplete -- so we I was never seeing the option.

Jonatha1983 commented 6 days ago

Thank you for providing me with this information!!!!

awindillman commented 6 days ago

More info: The blinking thing to the right of the text in the timeline is the popup menu being drawn over and over again. A simple.. as in short.. timeline does not have the issue. However if the PR has lots of comments, resolutions, events, etc then it happens every time.

Jonatha1983 commented 6 days ago

Sorry I did t get the last one, on which blinking you are talking about?

awindillman commented 6 days ago

Sorry I did t get the last one, on which blinking you are talking about?

This one..

In doing so I found that right-clicking to the right of the title on the timeline brings up a menu that blinks super-fast, but never really appears. It continues the blinking for about 30 seconds. Unfortunately, I could not capture a picture, but it reproduces every time.

Jonatha1983 commented 6 days ago

https://github.com/user-attachments/assets/ee12ca37-641b-4977-9563-d02b377faf3b

what am I missing?

awindillman commented 5 days ago

blinking_failed_to_reproduce.mov

what am I missing?

We're on Windows. That is likely a factor. Also, once I get it to succeed, it does work. I'll see if I can't get a movie for you.