search

edgafner / dorkag

Issue Tracker repository for all Dorkag plugins
Other
5 stars 0 forks source link

[BUG]:When adding reviewers, the list gets overwritten if filtered #158

Open awindillman opened 4 hours ago

awindillman commented 4 hours ago

Describe the bug If I need to "type down" to find the user or users I want to add, then click off the add dialog, only the filtered and checkboxed users are added.. not the ones I added from prior typedowns, and any prior adds (from adding earlier) are removed.

To Reproduce Steps to reproduce the behavior:

  1. Create a PR
  2. Check pencil to add a reviewer. Choose anyone and click off.
  3. Click the pencil to add a reviewer.
  4. Use the search and select a reviewer.
  5. Use the search (different search) and select a reviewer.
  6. Click off [to add the reviewers]

Only the reviewer added in Step 5 will remain

Expected behavior The reviewer added in step 2 should remain. The reviewers added in step 4 and 5 should remain.

Desktop (please complete the following information):

JetBrains IDE (please complete the following information):

Jonatha1983 commented 4 hours ago

Yeah, I saw that today as well. I think it is a regression.

Thanks for reporting.

Jonatha1983 commented 3 hours ago

@awindillman, I opened an issue with JetBrains about this since I could also reproduce it with the GitLab plugin.

It is something in the infrastructure that needs to be fixed on their side.

I will keep you posted when it is fixed.

Jonatha1983 commented 2 hours ago

This is the ticket you can check.

A simple workaround until they fix it is to clear the text after filtering and selecting—once it is clear, you can see all the selected users, for some reasons if the popup is closed before cleaning the filtered text it take in to account only the user selected with the filter.