[BUG]: Absence of ability to approve pull requests

[olegpoltora]

Describe the bug I can't see button for approving a pull request as I can see at screenshot at plugin's info page.

Screenshots It's YOUR screenshot at plugin's page:

It's mine photo (sorry for quality):

Desktop (please complete the following information):

• OS: Ubuntu 22.04.3 LTS

JetBrains IDE (please complete the following information):

• IDE: IntelliJ
• Version: IntelliJ IDEA 2023.3.2 (Ultimate Edition) Build #IU-233.13135.103, built on December 20, 2023

[olegpoltora]

Settings for repository:

[Jonatha1983]

Hi @olegpoltora

Will investigate this issue next week, thanks for reporting

[Jonatha1983]

@olegpoltora, sorry for the delay.

I looked, and it looks like your plugin user ID is different from the PR author ID - so I think it is a bug of mine, but yours is a particular case, and I need your help to spot the bug entirely.

Can you open a browser and paste this:

https://app.vssps.visualstudio.com/_apis/profile/profiles/me

and let me know if the email address you see there is the one of the PR's Author

Thanks

[MrBalum]

@Jonatha1983 Hello i encountered the same issue: Should i dump the respone of : https://app.vssps.visualstudio.com/_apis/profile/profiles/me

here ?

[Jonatha1983]

Hi @MrBalum

You can just let me Know if the email that appears there is the one you expect to be used to work with the plugin

And in case there is only one email in there - can you confirm that more than one user has the same email in Azure Devops organization?

[MrBalum]

@Jonatha1983 Yeah absoluty as expected. Username and Email-Adress is as Expected: My Actual Version of PHPStorm is: 2023.3.4

The Account is configured an i can work also with this account. I can comment and Manage PR´s but Approval is not functional. If i switch the plugin option Azure DevOps Theme on then a button appears to approve and if i select some of the options of the selectbox the Plugin does nothing there...

[Jonatha1983]

@MrBalum Thanks for the input!!

I am debugging - can you check this URL as well:

https://dev.azure.com//_apis/connectionData

and see if it has the following structure:

  authenticatedUser: {
    id: "XXXXXX",
    descriptor: "Microsoft.IdentityModel.Claims.ClaimsIdentity;EEEEEE\jgafner@dorkag.com",
    subjectDescriptor: "aad.XXXX",
    providerDisplayName: "jonathan gafner",
    isActive: true,
    properties: {
      Account: {
        $type: "System.String",
        $value: "jgafner@dorkag.com"
      }
    },
    resourceVersion: 2,
    metaTypeId: 0
  },
  authorizedUser: {
    id: "XXXXXX",
    descriptor: "Microsoft.IdentityModel.Claims.ClaimsIdentity;EEEEEE\jgafner@dorkag.com",
    subjectDescriptor: "aad.XXXXXX",
    providerDisplayName: "jonathan gafner",
    isActive: true,
    properties: {
      Account: {
        $type: "System.String",
        $value: "jgafner@dorkag.com"
      }
    },
    resourceVersion: 2,
    metaTypeId: 0
  },
  instanceId: "EEEE",
  deploymentId: "EEEE",
  deploymentType: "hosted",
  locationServiceData: {
    serviceOwner: "XXXXX",
    defaultAccessMappingMoniker: "PublicAccessMapping",
    lastChangeId: 43474974,
    lastChangeId64: 43474974
  }
}```

[MrBalum]

Hey @Jonatha1983 The Output ist exactly the same, only the ids are diffrent but this is expected :D

The Structure of our Team ist Organization/Project/Repo and i cant choose a other diffrent repository to work on ist that normal ? But i have the access rights for the other repos.

[Jonatha1983]

Hi @MrBalum

Can you check this version - should have a fix

https://github.com/edgafner/dorkag/issues/62#issuecomment-1962433366

I uploaded to the EAP channel a version that should work for your case:

Version 2024.1.28

https://plugins.jetbrains.com/plugin/22319-azd/edit/versions/eap

Just so you know, you must remove the old user if you have one - I tested this multiple times with different scenarios. I am pretty sure it should work well for your scenario, but please let me know if not.

[MrBalum]

Hey @Jonatha1983

i tried the new version and it seems like that this fix is incompatible with the whitespace in our Project Name

[Jonatha1983]

You need to remove old account - you can do it under settings > version control >azure devops

Then login again

[MrBalum]

I removed the old account reinstalled the plugin and used following server Syntax

https://dev.azure.com/

[Jonatha1983]

And that is the error you got?

[MrBalum]

Thats the ERROR: Could not connect to repository https://dev.azure.com/DEXPRO/DEXPRO%20Platform with account https://dev.azure.com/MrBalum@dexpro.de HTTP Request Request GET https://dev.azure.com/DEXPRO%2FDEXPRO%2520Platform%2F_apis%2Fgit%2Frepositories%2FSQUEEZE?includeParent=true&api-version=7.2-preview.1 failed with status code 404 and response body

Im acutally searching for the debug logs of the plugin to provide more informations

[Jonatha1983]

It is ok - I will upload in few hours a new version with a fix If you have a project without spaces to check will be great

You used the Pat token as is copied from azure devops rigth? Thanks for reporting

[Jonatha1983]

@MrBalum New EAP version: https://plugins.jetbrains.com/plugin/22319-azd/edit/versions/eap 2024.1.29 I tested it with organization, project, and repo with white spaces, and it worked.

Please let me know if it fixes this issue.

[MrBalum]

@Jonatha1983 great thanks to you my friend ! Hard work pays off ! It is working perfectly, the abillity of appoving is given ! Close that bug

[Jonatha1983]

@MrBalum, thank you for the update!!

If you could spare 20 seconds, I would greatly appreciate a kind review on the plugin marketplace page.

Your feedback helps me promote the plugin and continue dedicating time to its improvement.

Thanks!

[Jonatha1983]

You need to remove old account - you can do it under settings > version control >azure devops

Then login again

@olegpoltora