edgafner / dorkag

Issue Tracker repository for all Dorkag plugins
Other
5 stars 0 forks source link

[BUG]: Icon not showing in toolbar #83

Closed TonyCasey closed 3 weeks ago

TonyCasey commented 3 months ago

Describe the bug The expected AZD Plugin icon does not appear in the latest version of JetBrains Rider

To Reproduce Steps to reproduce the behavior:

  1. Open the IDE
  2. Look at the vertical toolbar on the left
  3. See AZD plugin icon is missing

Expected behaviour The AZD plugin icon should appear

Screenshots

Missing icon...

image

https git..

image

Using credential helper...

image

ssh un-ticked...

image

Azd the only plugin being used for Azure..

image

Desktop (please complete the following information):

JetBrains IDE (please complete the following information):

Azure Devops organization details:

Additional context It was visible at some stage but then disappeared with different Rider updates. I really want it for PR reviewing and updating

Thanks

Jonatha1983 commented 3 months ago

Hi @TonyCasey

Thanks for reporting this.

I see from the images that your server URL is ending with visualstudio.com Is this your Azure DevOps Server installation or the Azure DevOps service (the public cloud)?

If this is the Service it means you are using the legacy URL, is that right?

TonyCasey commented 3 months ago

Yeah, that's right, it's the Azure DevOps service (the public cloud)

In fact I have some projects that use dev.azure.com and I can see the icon...

image

Is there a way to work with legacy repo's?

Many thanks

Jonatha1983 commented 3 months ago

Yes, the plugin supports the legacy - but what is strange in your previous images is that in the URL, the place where the Organization Name should be is DefaultCollection.

The plugin was implemented to follow the URL structure in the link I sent previously. So if, for example, my Azure DevOps service with legacy URL is:

https://azd.visualstudio.com

The plugin is assuming that my organization name is azd, but in your case it looks like it is a different case.

I suggest you try to change the git remote to follow the convention; I am pretty sure it will work for you the same way. So what you can do is remove and add the git remote URL so in case your organization name is DefaultCollection, it will be: https://DefaultCollection.visualstudio.com And if the org name is the prefix in your URL that you obfuscated, I am wondering what the DefaultCollection is later in the URL.

Jonatha1983 commented 2 months ago

@TonyCasey, can you please update us on this issue?

Is it solved, or are you still facing issues?

Thanks

TinyDinosaur commented 2 months ago

Hi guys. I confirm this is happening to me as well. Not sure if this was triggered by the update to Rider 2023.3. I have the exact same setup as described in the bug :/

Jonatha1983 commented 2 months ago

@TinyDinosaur thanks for the update.

Can you turn on the statistic checkbox under the plugin settings and retry.

I ll try to see if I can spot some exceptions.

In addition did you insert the url server including the Collection name?

TonyCasey commented 2 months ago

Sorry for the delay in the response.

I haven't got it working yet.

I tried with the "git clone" link provided in Azure ..

https://[organization]@dev.azure.com/[organization]/[project]/_git/[repository]

and got this...

image

Jonatha1983 commented 2 months ago

@TonyCasey If your organization is set with the legacy you need to also clone using the legacy.

I need a bit more details to help you in here.

bertenvdb commented 1 month ago

I have the same problem, no AZD toolbar icon or menu entries.

I'd turn on the plugin statistics, but can't find the plugin settings page... image

No toolbar icon or tool window: image

image

[Edit] Will first try to update rider...

Jonatha1983 commented 1 month ago

Hi @bertenvdb

Thanks for updating on this issue.

In one of your screenshots, I see this: image

If you click on it, nothing happens.

Also, the statistics are in the setting here: image

Can you see if you spot any exceptions in the idea logs?

From the Azure DevOps URL image, I suspect that it may be a regression related to the spaces in the URL. Is there any chance you have another project without spaces in the URL to check?

Sorry about the inconvenience

bertenvdb commented 1 month ago

Updating Rider to 2024.1.3 fixed it for me. Also works with the repo with spaces in the URL.

Thanks, and keep up the great work!

Jonatha1983 commented 1 month ago

@bertenvdb Great thanks for the update.

If you have 1 min spare will really appreciate a nice review on the marketplace🙏🏻

It helps me getting more users and gives me the option to keep working on this.

Thanks cheers

Jonatha1983 commented 3 weeks ago

@TonyCasey @TinyDinosaur I am closing this issue.

If you are still having issues with the Toolwindow opening - please let me know, and I'll reopen it.

ricardoboss commented 4 days ago

@Jonatha1983 I'm seeing this issue with on-premise ADO. No tool window icon whatsoever, not even when I check the repository out via the plugin UI.

Jonatha1983 commented 4 days ago

Hi @ricardoboss

Which IDE and which version?

ricardoboss commented 4 days ago

@Jonatha1983

JetBrains Rider 2024.1.4
Build #RD-241.18034.76, built on June 23, 2024
Licensed to Ricardo Boss
You have a perpetual fallback license for this version.
Subscription is active until July 28, 2025.
Runtime version: 17.0.11+1-b1207.24 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.5
.NET Core v8.0.1 ARM64 (Server GC)
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 8
Metal Rendering is ON
Registry:
  ide.instant.shutdown=false
  external.system.auto.import.disabled=true
  ide.experimental.ui=true
  ide.text.editor.with.preview.show.floating.toolbar=false
  git.show.recent.checkout.branches=0
  ide.new.project.model.index.case.sensitivity=true
Non-Bundled Plugins:
  com.supermaven.intellij (1.37)
  cognitivecomplexity-rider (2024.1.2)
  lermitage.intellij.extratci (2024.1.1)
  Key Promoter X (2024.1.0)
  com.intellij.plugin.adernov.powershell (2.6.1)
  com.intellij.mermaid (0.0.22+IJ.232)
  com.nasller.CodeGlancePro (1.8.5)
  CyclomaticComplexity (2024.1.2)
  com.wakatime.intellij.plugin (14.4.0)
  name.kropp.intellij.makefile (241.14494.150)
  ru.adelf.idea.dotenv (2024.1)
  Dart (241.17890.8)
  com.github.dinbtechit.vscodetheme (1.10.10)
  com.gafner.azd (2024.1.72)
  zielu.gittoolbox (500.2.10+233)
  mobi.hsz.idea.gitignore (4.5.3)
  org.jetbrains.advocates.rider.plugins.dotnetwatch (2024.1.1)
Jonatha1983 commented 4 days ago

What is the output format of git remote -vv

? Are you using https or ssh for git?

What is the format of your azure devops url? (No need for the real url just the format with and without a repo in the url - Https://your.org/DefaultColletin)

Are you working with multiple git remotes? Git sub modules ? Is the project opened from the git root folder?

ricardoboss commented 4 days ago

git remote -vv

origin  ssh://<custom host>:22/<collection>/<project>/_git/<repo name> (fetch)
origin  ssh://<custom host>:22/<collection>/<project>/_git/<repo name> (push)

I prefer using ssh to clone repositories. Not using any submodules for this particular repository. Solution is in the git repo root

When I access the repository from a browser, I go to:

https://<custom host>/<collection>/<project>/_git/<repo name>

We actually use many different collections based on the kind of project we are working with (we have a collection "Technical" for internal tools and a collection "Products" for products we develop for example).

Jonatha1983 commented 4 days ago

Did you configured a proxy in your ide?

You can check Under Appearance & Behavior > System Settings > HTTP Proxy

If yes that is the cause - the plugin currently doesn't work when a proxy is configured If not can you check if you see some errors in the ide logs?

About multiple collections/organization the plugin should know how to deal with that.

Jonatha1983 commented 4 days ago

One more question - Under Settings> Version control > Git

Is your use credential helper is checked?

ricardoboss commented 4 days ago

Did you configured a proxy in your ide?

No, not using any proxies.

If not can you check if you see some errors in the ide logs?

Yes, I found this warning:

2024-07-11 16:56:56,374 [278275966]   WARN - #com.gafner.plugin.azd.notification.AZDPushNotificationCustomizer - Failed to lookup an existing merge request for SUCCESS (2, 'refs/heads/features/register'), update: null}
java.lang.IllegalArgumentException: URI with undefined scheme
    at java.net.http/jdk.internal.net.http.common.Utils.newIAE(Utils.java:286)
    at java.net.http/jdk.internal.net.http.HttpRequestBuilderImpl.checkURI(HttpRequestBuilderImpl.java:79)
    at java.net.http/jdk.internal.net.http.HttpRequestBuilderImpl.<init>(HttpRequestBuilderImpl.java:55)
    at java.net.http/java.net.http.HttpRequest.newBuilder(HttpRequest.java:305)
    at com.intellij.collaboration.api.HttpApiHelperImpl.request(HttpApiHelper.kt:75)
    at com.gafner.plugin.azd.api.AZDApiImpl.request(AZDApi.kt)
    at com.gafner.plugin.azd.api.AZDApiImpl$RestImpl.request(AZDApi.kt)
    at com.gafner.plugin.azd.api.request.AZDUsersApiKt.getCurrentRepoInfo(AZDUsersApi.kt:46)
    at com.gafner.plugin.azd.notification.AZDPushNotificationCustomizer$getReviewBranch$repoInfo$1.invokeSuspend(AZDPushNotificationCustomizer.kt:93)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
    at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)
    at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

But its a few days old and from the branch name (refs/heads/features/register) I conclude that it is also a different repository.

Is your use credential helper is checked?

Yes.

Jonatha1983 commented 4 days ago

When using ssh usually the use credential helper should be unchecked- can you try to uncheck and see if it solve the issue?

ricardoboss commented 4 days ago

About multiple collections/organization the plugin should know how to deal with that.

Yeah about that... It's not ideal that I can't add one account for all collections, I have to add one for every collection.

Also, in the list of repositories, it's quite confusing that the repositories are listed without their projects.

azd

Jonatha1983 commented 4 days ago

Yes, I found this warning:

Did you change the remote of this repository lately?

Jonatha1983 commented 4 days ago

I ll open a ticket to add the organization / project next to the repo 👍🏻 thanks

Jonatha1983 commented 4 days ago

You don't need to add a user for each collection - if your token is set with access all organization/collection it should work for all- if not it is a bug

ricardoboss commented 4 days ago

When using ssh usually the use credential helper should be unchecked- can you try to uncheck and see if it solve the issue?

Makes no difference as far as I can tell. Disabled it, restarted the IDE, opened the project but still no tool window.

Did you change the remote of this repository lately?

No, as I said, it's from a different project und unrelated.

You don't need to add a user for each collection - if your token is set with access all organization/collection it should work for all- if not it is a bug

That could be because of our on-promise solution. I can't add the root for some reason (I have a suspicion, not related to your plugin) so I have to add every collection one-by-one.

Jonatha1983 commented 4 days ago

Wait your token was created without settings the "all accessible organizations" ?

ricardoboss commented 4 days ago

No, I'm using the same PAT for all collections and the PAT has that permission.

Jonatha1983 commented 4 days ago

Did it worked for you previously and it stopped working? Or never worked?

Also under Appearance > System Settings > Password

Are you using a native keychain?

If yes can you try to switch to in keepas?

Sorry for asking so much question but I really trying to figure out the issue

I will also use the stack trace provided in the warning.

ricardoboss commented 4 days ago

Did it worked for you previously and it stopped working? Or never worked?

I just checked something - The repository contains a .NET solution and a Flutter project. The .NET solution is opened in Rider where the tool window does not show up. The Flutter project on the other hand is open in Android Studio.

The tool windows in Android Studio show up and work perfectly fine. This is in the same folder, the same repository. The flutter project is not even in the root of the repository

Seems to be Rider related then?

Are you using a native keychain?

Yes, both Android Studio and Rider are using native keychain

Jonatha1983 commented 4 days ago

Yes sound like that, it also confirm what happen to @bertenvdb - when he changed the rider version the issue was fixed

Jonatha1983 commented 4 days ago

@ricardoboss FYI - #101 is for the clone repo list issue.