search

edgafner / dorkag

Issue Tracker repository for all Dorkag plugins
Other
5 stars 0 forks source link

[BUG]: Editor selected code is not what is commented on #93

Open Crimix opened 1 month ago

Crimix commented 1 month ago

Describe the bug When adding a comment to a line of code, it does not respect what it selected on the line. This makes it hard to comment on specific things, liked input arguments

To Reproduce Steps to reproduce the behavior:

  1. Review an PR in the editor view
  2. Mark something on the line
  3. Click the "+" in the gutter to comment
  4. Submit comment
  5. The comment appears to have selected only the first

Expected behavior I excepted the comment to be added with the selected code

JetBrains IDE (please complete the following information):

Jonatha1983 commented 1 month ago

@Crimix hi, thanks for reporting.

Currently multi line comment is not supported, there is an open ticket about it. Hope to get to it for the upcoming release.

Will keep you updated.

Crimix commented 1 month ago

I did see it, I was hoping it would use my selection when it is not a multi line comment

Jonatha1983 commented 1 month ago

So you are saying that you click on 1 line in the PR and add a comment, and when going to the Azure DevOps, the comment is on a different line?

Could you add the comment on a specific PR and not when it was on all commits? See image: image image image

Crimix commented 1 month ago

No I am saying that it will mark the first 8-10 characters on the line no matter where I placed my mouse on the line. Is that also related to the multi line feature?

Jonatha1983 commented 1 month ago

The smallest granular level is a line not chars in a line - this is the same in Azure DevOps no?

Crimix commented 1 month ago

Yes, but the difference is that when adding a line comment in Azure DevOps. It will mark the full line. If I add it though the plugin, it will only mark like 10 characters for the comment and now the full line

Jonatha1983 commented 1 month ago

Can you show images of what you mean I don't completely understand

Crimix commented 1 month ago

Here I place a line comment though the plugin image