search

edgar-mtz-e / slimdx

Automatically exported from code.google.com/p/slimdx
0 stars 0 forks source link

New feature: EffectCompiler.FromMemory and EffectCompiler.FromStream #309

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The attached patch adds two methods to EffectCompiler:
FromMemory - creates an effect compiler from a string
FromStream - creates an effect compiler from a string in a stream

Original issue reported on code.google.com by m...@andreloker.de on 25 Jul 2008 at 8:34

Attachments:

GoogleCodeExporter commented 9 years ago 
Here's a revised version of the patch (fixes minor issues in the XML docs)

Original comment by m...@andreloker.de on 25 Jul 2008 at 9:04

Attachments:

GoogleCodeExporter commented 9 years ago 
Hmm, EffectCompiler hasn't been touched in a very long time. Once I go over it
everything should be up to code.

Original comment by Mike.Popoloski on 29 Jul 2008 at 3:10

GoogleCodeExporter commented 9 years ago 
On a second look, it appears that this functionality is already in 
EffectCompiler, in
the form of the two constructors. This may change in the future, but for now I'm
going to close this.

Original comment by Mike.Popoloski on 2 Aug 2008 at 2:02

GoogleCodeExporter commented 9 years ago 
Hm, strange that I overlooked the c'tors. Sorry for that! Somehow I was used to 
the
FromXXX pattern.

Original comment by m...@andreloker.de on 2 Aug 2008 at 9:40

GoogleCodeExporter commented 9 years ago 
Yes, it's a bit strange and doesn't quite fit into the pattern we've 
established, so
I'll probably end up changing it to FromXXX methods.

Original comment by Mike.Popoloski on 2 Aug 2008 at 11:28