search

edgarcosta / endomorphisms

Rigorous computation of the endomorphism ring of a Jacobian
GNU General Public License v2.0
10 stars 8 forks source link

polredbesting is betterer #28

Closed AndrewVSutherland closed 5 years ago

AndrewVSutherland commented 5 years ago

The caller can always decide whether they want to polredabs the final result or not, but for intermediate results used by the algorithm I see no reason to polredabas anything (unless you are relying on the defining polynomial to uniquely identify a field somewhere in the code).

When the endomorphism fields get big, polredabsing becomes the bottleneck -- eventually you will hit a field discriminant you are never going to factor and then you are done. But if you instead polredbest (which I have done locally in my own fork), you can often get computations to complete that otherwise never would.

I'd like to see polredbesting made the "official" default behavior so that I don't have to retweak the code (or stash my changes) everytime I pull a new version, and so I don't have to worry that I am making a change that will break something I am unaware of.

edgarcosta commented 5 years ago

I agree.

JRSijsling commented 5 years ago

Only bester, not betterer, is better than best... but I digress. This is now the default.