edgarcosta / endomorphisms

Rigorous computation of the endomorphism ring of a Jacobian
GNU General Public License v2.0
10 stars 8 forks source link

Homogenize #37

Closed jvoight closed 4 years ago

jvoight commented 4 years ago

Line 36 of /magma/heuristics/Curves.m calls a function called Homogenize. I think this is a unlinked dependency. I know it's not a standard Magma function, because they would insist on calling it Homogenization.

jvoight commented 4 years ago

OK found it here: https://gist.github.com/edgarcosta/52eb0a8de56d78724be6c07f63ac2caa

I'm happy instead to copy the function over (and decline my pull request).

edgarcosta commented 4 years ago

My guess is that @andrewvsutherland created his own function for some reason, so perhaps its better to incorporate Drew's function instead of using Magma's. That we also are sure that we won't break anything

edgarcosta commented 4 years ago

@jvoight, @JRSijsling added the function https://github.com/edgarcosta/endomorphisms/blob/master/endomorphisms/magma/heuristic/Curves.m#L33