search

edgarcosta / endomorphisms

Rigorous computation of the endomorphism ring of a Jacobian
GNU General Public License v2.0
10 stars 8 forks source link

Poldred #51

Closed edgarcosta closed 2 years ago

edgarcosta commented 2 years ago

The old Polredabs became Polred where picks polredbest/polredabs base on the degree being smaller or larger than 8. And created the versions Polredabs and Polrebest where it calls what the name says.

Also replaced all the old calls of Polredabs with Polred.

and left this call to Polredbestabs intact https://github.com/edgarcosta/endomorphisms/blob/master/endomorphisms/magma/roots.m#L77

edgarcosta commented 2 years ago

@SamSchiavone @JRSijsling , see if you agree

SamSchiavone commented 2 years ago

The code looks good to me. I think it might make sense to put this in a separate repo MagmaPolred. Then we'd have one portable Magma version of the various polred-s in one place.

edgarcosta commented 2 years ago

I can do that

On Fri, Sep 9, 2022, 15:27 Sam Schiavone @.***> wrote:

The code looks good to me. I think it might make sense to put this in a separate repo MagmaPolred. Then we'd have one portable Magma version of the various polred-s in one place.

— Reply to this email directly, view it on GitHub https://github.com/edgarcosta/endomorphisms/pull/51#issuecomment-1242494109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACO2BWDOKJPKJ73QBXSZ53V5OTS7ANCNFSM6AAAAAAQI4UGR4 . You are receiving this because you authored the thread.Message ID: @.***>

edgarcosta commented 2 years ago

done. I have updated the readme and created the repo https://github.com/edgarcosta/MagmaPolred

please check the readme changes