edgarcosta / hilbertmodularforms

Mockup implementation of Hilbert Modular Forms
BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

replace TotallyPositiveUnits with TotallyPositiveUnitsGroup #463

Closed abhijit-mudigonda closed 4 months ago

abhijit-mudigonda commented 4 months ago

The name TotallyPositiveUnits conflicts with an existing attribute in Magma, so we rename ours to avoid issues.

edgarcosta commented 4 months ago

lgtm